Revert "tools/libxc: Drop broken xc_{get,set}_hvm_param() functions"
authorWei Liu <wei.liu2@citrix.com>
Wed, 31 May 2017 10:35:25 +0000 (11:35 +0100)
committerWei Liu <wei.liu2@citrix.com>
Wed, 31 May 2017 10:35:25 +0000 (11:35 +0100)
This reverts commit fa4583333ddba6afb7b07ff7eb4d16e1a6a7459c.

QEMU build is broken by that patch.

tools/libxc/include/xenctrl.h
tools/libxc/xc_domain.c
tools/xenpaging/xenpaging.c

index 4d3f2ae9c815160106d3f720d070de5be7f588a9..1629f412dd02d42613d226893774e48f1e21c52a 100644 (file)
@@ -1660,6 +1660,10 @@ void xc_clear_last_error(xc_interface *xch);
 int xc_hvm_param_set(xc_interface *handle, domid_t dom, uint32_t param, uint64_t value);
 int xc_hvm_param_get(xc_interface *handle, domid_t dom, uint32_t param, uint64_t *value);
 
+/* Deprecated: use xc_hvm_param_set/get() instead. */
+int xc_set_hvm_param(xc_interface *handle, domid_t dom, int param, unsigned long value);
+int xc_get_hvm_param(xc_interface *handle, domid_t dom, int param, unsigned long *value);
+
 /* HVM guest pass-through */
 int xc_assign_device(xc_interface *xch,
                      uint32_t domid,
index b6194407b4fa192f3c631788bbd75a8e169cdbaa..00909ad470570d3cdce0bd53ab48fa59ce64a2cb 100644 (file)
@@ -1455,6 +1455,23 @@ int xc_hvm_param_get(xc_interface *handle, domid_t dom, uint32_t param, uint64_t
     return rc;
 }
 
+int xc_set_hvm_param(xc_interface *handle, domid_t dom, int param, unsigned long value)
+{
+    return xc_hvm_param_set(handle, dom, param, value);
+}
+
+int xc_get_hvm_param(xc_interface *handle, domid_t dom, int param, unsigned long *value)
+{
+    uint64_t v;
+    int ret;
+
+    ret = xc_hvm_param_get(handle, dom, param, &v);
+    if (ret < 0)
+        return ret;
+    *value = v;
+    return 0;
+}
+
 int xc_domain_setdebugging(xc_interface *xch,
                            uint32_t domid,
                            unsigned int enable)
index 431a86b77cb150cdb407e138b93915c8f1928ed5..d0571cabaca6690cbf53d26fe67d5c1a01dc65f6 100644 (file)
@@ -280,8 +280,7 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
     xentoollog_logger *dbg = NULL;
     char *p;
     int rc;
-    uint64_t ring_pfn;
-    unsigned long mmap_pfn;
+    unsigned long ring_pfn, mmap_pfn;
 
     /* Allocate memory */
     paging = calloc(1, sizeof(struct xenpaging));
@@ -339,8 +338,8 @@ static struct xenpaging *xenpaging_init(int argc, char *argv[])
     }
 
     /* Map the ring page */
-    xc_hvm_param_get(xch, paging->vm_event.domain_id,
-                     HVM_PARAM_PAGING_RING_PFN, &ring_pfn);
+    xc_get_hvm_param(xch, paging->vm_event.domain_id, 
+                        HVM_PARAM_PAGING_RING_PFN, &ring_pfn);
     mmap_pfn = ring_pfn;
     paging->vm_event.ring_page = 
         xc_map_foreign_pages(xch, paging->vm_event.domain_id,